Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory for meryl count to avoid crash #7074

Closed
wants to merge 2 commits into from

Conversation

MartinPippel
Copy link
Contributor

Avoid that meryl count crashes due to memory issues. It seems that meryl uses the complete buffer provided via memory=SIZE for the kmer counts, but meryl itself uses some memory too. When using meryl count within singularity containers and slurm, then usually slurm is killing meryl due to that overhead.

Solution, reduce the meryl memory kmer buffer task.memory by 10%. This is potentially a bit to much as usually the memory overhead was around 2-4Gb, but it solved all my issues on 3 three different compute clusters (Uppmax rackham, PDC dardel, and nac).

@MartinPippel MartinPippel self-assigned this Nov 24, 2024
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but need to get the tests working.

@SPPearce
Copy link
Contributor

Is the same issue happening with MERFIN here?

@mahesh-panchal
Copy link
Member

No, it's also things like version strings are different between meryl conda ( doesn't have one ) and meryl singularity ( 1.4.1 ).
I'm not sure what else is different atm.

@SPPearce
Copy link
Contributor

MERFIN_HIST is also failing, so might be as well as the other issues:
https://github.com/nf-core/modules/actions/runs/12006625811/job/33465567907?pr=7074#step:4:413

mahesh-panchal added a commit to MartinPippel/NFcore_modules that referenced this pull request Dec 4, 2024
@mahesh-panchal
Copy link
Member

When #6921 is merged, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants