Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove soft-linking of fasta instead stage in dir #7081

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

sateeshperi
Copy link
Contributor

@sateeshperi sateeshperi commented Nov 25, 2024

To avoid nested symlinks, the changes here mount the correct dir of fasta file onto container for original symlink to work

Thanks to @mahesh-panchal for this fix! ❤️

+

enclosing all input variables with ${}

modules/nf-core/bismark/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/bismark/coverage2cytosine/main.nf Outdated Show resolved Hide resolved
@sateeshperi sateeshperi added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@sateeshperi sateeshperi added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 7992214 Nov 26, 2024
27 checks passed
@sateeshperi sateeshperi deleted the fix/bismark-apps branch November 26, 2024 04:44
LouisLeNezet pushed a commit to LouisLeNezet/modules that referenced this pull request Dec 4, 2024
* remove soft-linking of fasta instead stage in dir

* add comments for fasta stageAs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants