Fix ci confirm pass #7186
Merged
Fix ci confirm pass #7186
+46
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sateeshperi
commented
Dec 10, 2024
sateeshperi
commented
- Update confirm-pass jobs to correctly identify failed & cancelled
- touch a gpu & cpu module to test
GallVp
approved these changes
Dec 10, 2024
mashehu
approved these changes
Dec 10, 2024
adamrtalbot
reviewed
Dec 13, 2024
Comment on lines
+119
to
+121
| - name: All tests ok | ||
| if: ${{ contains(needs.*.result, 'success') }} | ||
| run: exit 0 |
There was a problem hiding this comment.
@sateeshperi This will now pass if any test passes with a success status. That's why it negated the presence of a 'failure' status before.
There was a problem hiding this comment.
negated the presence of which failure status ?
There was a problem hiding this comment.
.* is not for any single test. It is for all members of 'needs' which has only one element here so it just stands for 'nf'test-gpu'.
Secondly, if any test fails, the fail branch will be triggered first as it is now placed above the pass branch.
I created this new confirm-pass in methylseq and we tested it quite a bit with multiple runs where tests were passing, failing, being skipped, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.