Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU profile for Cellpose #90

Closed
wants to merge 31 commits into from
Closed

Conversation

kbestak
Copy link
Collaborator

@kbestak kbestak commented Oct 30, 2024

Added a GPU profile for Cellpose that works on our HPC cluster with Slurm.
No tests added - is CI with GPU possible here for testing?
TODO: add documentation, update changelog

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

kbestak and others added 30 commits January 3, 2024 09:31
Co-authored-by: Florian Wuennemann <[email protected]>
Merging template updates, dev version bump after release, module update
Co-authored-by: Florian Wuennemann <[email protected]>
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @kbestak,

It looks like this pull-request is has been made against the kbestak/nf_molkart master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the kbestak/nf_molkart dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

Copy link

github-actions bot commented Oct 30, 2024

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 5904f3e

+| ✅ 221 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • nextflow_config - Config manifest.version should not contain dev for a release: 1.1.0dev
  • version_consistency - manifest.version was not numeric: 1.1.0dev!
  • included_configs - Pipeline config does not include custom configs. Please uncomment the includeConfig line.

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-30 11:08:52

@kbestak kbestak closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants