Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release #150

Merged
merged 18 commits into from
Sep 19, 2024
Merged

Prepare release #150

merged 18 commits into from
Sep 19, 2024

Conversation

luisas
Copy link
Collaborator

@luisas luisas commented Sep 18, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/multiplesequencealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fef23cc

+| ✅ 194 tests passed       |+
#| ❔  21 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-19 14:46:47

@lrauschning
Copy link
Contributor

Hm, seems like an internal issues with multiqc?
The trace points to this line, which is throwing a pydantic error. Not familiar with multiqc, but might be worth opening an issue there?

@luisas
Copy link
Collaborator Author

luisas commented Sep 19, 2024

This PR is not ready yet, still WIP

@lrauschning
Copy link
Contributor

Ah nevermind then, just saw it was open when opening the other one and had a look :)

@luisas
Copy link
Collaborator Author

luisas commented Sep 19, 2024

all good - now it should be finished :)

@luisas luisas merged commit 83b2cf2 into nf-core:dev Sep 19, 2024
16 checks passed
@luisas luisas deleted the prepare-release branch September 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisas @lrauschning @sateeshperi