-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metromap and logo #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this. Here is some feedback: It is not clear what the meaning of the different color routes mean. They seem to represent different files, but they normally should represent methods (see rnaseq, sarek or taxprofiler). There is also no need to clarify in a legend if something is a module/subworkflow since the diagram is already too simplified. I do see a value in clarifying which are mandatory/optional (see sarek as an example).
The colors effectively represent the samplesheet the user will give ( |
I understand you added a legend for the colours. I think you want to keep the colours for an aesthetic reason but I do not think they follow the same pattern as all nf-core pipelines. I don’t think there is any issue in keeping a simple colour schema. It doesn’t have to have plenty of colours if it doesn’t need to. If you really want to use colours, one possibility would be to color paths according to the step. For example all lines to outputs in panelprep are one colour (instead of having orange, red and blue, they can be all orange). Then the lines that are inputs to imputation are another colour (now they are red, blue, orange, green, they could be all green). Then the input to validate another colours (now green and yellow, they could be all yellow). Same with simulate (now green, it can be kept green / or any different colour to the other steps). This way, you would keep the colours but respect the “functionality” of how colour tubes are used in other nf-core pipelines. |
Update the main metro map and add the different version of the pipeline logo with the dog symbol.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).