Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FUSIONREPORT_DOWNLOAD: remove double nested folder #581

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix FUSIONREPORT_DOWNLOAD: remove double nested folder #581

merged 6 commits into from
Dec 10, 2024

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Dec 10, 2024 •
edited
Loading

#577 introduced a double folder structure for fusion_report_db, this PR removes one layer

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@rannick rannick requested a review from atrigila December 10, 2024 12:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 87f5ff8

+| ✅ 222 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-10 14:26:53

atrigila
atrigila requested changes Dec 10, 2024
View reviewed changes
Copy link

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only thing could be that the output now changed from fusionreport_db to fusionreport_ref, which needs to be updated in the nf-test of FUSIONREPORT_DETECT for it to work :)

@rannick rannick self-assigned this Dec 10, 2024
@rannick rannick requested a review from atrigila December 10, 2024 14:57
@rannick rannick merged commit 1ae795e into dev Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

Assignees

@rannick rannick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rannick @atrigila