Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oncoanalyser] Add simulated test read data and samplesheets #1270

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

scwatts
Copy link

@scwatts scwatts commented Jul 31, 2024


Help wanted/needed: the merge target is current nf-core:master and should be nf-core:oncoanalyser instead but this branch does not yet exist. The documentation doesn't have the answer from what I understand but I suspect nf-core:oncoanalyser will need to be created first.

SPPearce
SPPearce previously approved these changes Jul 31, 2024
@SPPearce SPPearce dismissed their stale review July 31, 2024 06:50

Question

@scwatts scwatts added the help wanted Extra attention is needed label Jul 31, 2024
@SPPearce
Copy link

SPPearce commented Jul 31, 2024

Sorry for the unapproval, but I realised that this was an issue.
You shouldn't merge into master, you should be merging into an oncoanalyser branch on the nf-core repo.
Which I see that you have written in the body of the message.

@SPPearce SPPearce changed the base branch from master to oncoanalyser July 31, 2024 08:08
Copy link

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.
I have made a nf-core oncoanalyser branch via going to https://github.com/nf-core/test-datasets/branches and clicking New Branch, and then selected that branch to merge into.

@scwatts
Copy link
Author

scwatts commented Jul 31, 2024

Argh, I just made a branch as well! Not great timing on my part but thank you!

@scwatts scwatts merged commit a9a7c25 into nf-core:oncoanalyser Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants