Remove toList() channel operation from inside onComplete block #3304
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
reviewed
Dec 2, 2024
nf_core/pipeline-template/subworkflows/nf-core/utils_nfcore_pipeline/main.nf
Outdated
Show resolved
Hide resolved
nf_core/pipeline-template/subworkflows/local/utils_nfcore_pipeline_pipeline/main.nf
Outdated
Show resolved
Hide resolved
robsyme
force-pushed
the
remove-channel-operations-from-oncomplete
branch
3 times, most recently
from
9f74724
to
e1f07d5
Compare
This PR resolves an important bug in the nf-core template, whereby all workflows will hang if the --email parameter is supplied. The onComplete block will hang if there are any (queue) channel operations inside the block. All values in the onComplete block must be resolved to single values or value channels _before_ the onComplete block starts. The async channels are not available inside onComplete, so calling the toList() operation will hang forever as the async queue channel will never be completed.
robsyme
force-pushed
the
remove-channel-operations-from-oncomplete
branch
from
e1f07d5
to
abb0fa2
Compare
|
Needs nf-core/modules#7129 |
…annel-operations-from-oncomplete
5 tasks
|
Maybe we can drop the changes to nf_core/pipeline-template/subworkflows/nf-core/utils_nfcore_pipeline/main.nf to keep this PR focused. |
…s_nfcore_pipeline/main.nf
I thought both changes were tied together. But we can also update the subworkflow on a different PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an important bug in the nf-core template, whereby all workflows will hang if the --email parameter is supplied.
The onComplete block will hang if there are any (queue) channel operations inside the block. All values in the onComplete block must be resolved to single values or value channels before the onComplete block starts.
The async channels are not available inside onComplete, so calling the toList() operation will hang forever as the async queue channel will never be completed.
PR checklist
CHANGELOG.mdis updateddocsis updated