Fix meta_yml linting error #3317
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the issue was added here when the test was added back, but it was not so obvious that |
mirpedrol
approved these changes
Dec 4, 2024
| @@ -96,6 +95,9 @@ def __init__( | |||
| self.test_yml = None | |||
| self.test_main_nf = None | |||
|
|
|||
| # Set process_name after self.main_nf is defined | |||
| self.process_name = self._get_process_name() | |||
There was a problem hiding this comment.
Suggested change
| self.process_name = self._get_process_name() | |
| self.process_name: String = self._get_process_name() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.mdis updatedDescription
This PR is to fix an issue where running
nf-core modules lint -a -k meta_ymlalways has failing tests due tomodule.process_namealways being""in nfcore_component.py.It gets initialized to
""then eventually gets updated inmain_nfbut not in any others which results in the failedmeta_ymltests unless-k main_nfis specified as wellI've added a simple function for the component to set it's
process_nameitself rather than it being set in other separate parts of the code. It uses the same regex expression thatmain_nf.pyuses