Feature/pid model improvements #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoerr
commented
Dec 3, 2024
markdoerr
commented
- some suggestions (as discussed) for the improvements of the terms (making them clearer)
- removing obsolete fields in the handle record schema
- fixing some typos
dalito
reviewed
Dec 3, 2024
| @@ -141,9 +142,10 @@ slots: | |||
| multivalued: true | |||
| description: Relations of the resource to other identifiers | |||
| dc_rights: | |||
| # TODO: why not call it just license(s) ? | |||
There was a problem hiding this comment.
Yes. Please change directly to license.
There was a problem hiding this comment.
Please rename file to "README.md"
| @@ -60,6 +60,7 @@ classes: | |||
| PID4CatRelation: | |||
| description: >- | |||
| A relation between PID4CatRecords or between a PID4CatRecord and other resources with a PID. | |||
| # TODO: please provide and example for this class | |||
There was a problem hiding this comment.
Please remove. General todos should better be issues. There is already #24 for this.
| slot_uri: schema:email | ||
| description: Identification of the agent that registered the PID, with | ||
| contact information. Should include person name and affiliation, or position | ||
| name and affiliation, or just organization name. e-mail address is preferred | ||
| contact information. | ||
| person_orcid: | ||
| TODO: should be better defined - to be clearly parsable by machines |
There was a problem hiding this comment.
Yes! This should also have the email-regex as above for curation_contact pattern: "^\\S+@[\\S+\\.]+\\S+"
Feel free to add it already now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.