-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable check for metadata sheetname and is meta data sheet for arc template #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update references below to use the new isMetadataSheet logic.
Similiar to here:
ARCtrl/src/Spreadsheet/ArcAssay.fs
Line 104 in 444df04
let tryGetMetadataSheet (doc : FsWorkbook) = |
Hey, the Commit (and by this also PR message) could be a bit more concise. Especially Also you should extend the logic to match that of ArcAssay and ArcStudy. Making use of the function you created. This way it would also transitively be tested. EDIT: Just as @Freymaurer also mentioned |
Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, usage of the newly added function in the "fromFsWorkbook" function is still missing. Line 277 including your changes
@HLWeil Do you mean in the tests? |
Closes Issue #453