Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LDObject, add ISA model API #478

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve LDObject, add ISA model API #478

wants to merge 3 commits into from

Conversation

kMutagene
Copy link
Member

This PR (eventually)

  • slightly remodels LDObject to use arrays for @type and additionalType. Json encode/decode was adapted to be able to parse string OR array fields, but ALWAYS write array fields (even for singletons)
  • Adds many API functions to get typed properties from ISA LDObjects (e.g., get all Persons as a Person [] from the given Investigation LDObject)

@kMutagene kMutagene linked an issue Nov 21, 2024 that may be closed by this pull request
[Feature Request] RO Crate Datamodel - ISA Profile: Add typed getter/setter APIs for known fields #433
Open
This was referenced Nov 21, 2024
Merged
Closed
@kMutagene
Copy link
Member Author

Blocked by CSBiology/DynamicObj#35 as we need the fixed version of CopyDynamicPropertiesTo to correctly set only dynamic props when trying to 'upcast', e.g. aDynamicObj as a LDObject, which has some static members in contrast to a fully dynamic DynamicObj

@kMutagene
Add LDObject.tryFromDynamicObj + tests
d2c4cd4
@kMutagene
LDObject: model @type/additionalType as arrays:
45463bf 
- Json: parse `@type`/`additionalType` from either string (-> singleton) or array field, always write array
- add tests
@kMutagene
Fix running single test projects
f593375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] RO Crate Datamodel - ISA Profile: Add typed getter/setter APIs for known fields
1 participant
@kMutagene