Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature excel update term to unit #502

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

Etschbeijer
Copy link
Collaborator

Closses Issue #454

@Etschbeijer Etschbeijer self-assigned this Aug 5, 2024
@Freymaurer Freymaurer changed the base branch from main to developer August 5, 2024 13:23
@@ -36,6 +36,17 @@ let private shortCutIconList model dispatch =
SpreadsheetInterface.CreateAnnotationTable ctrl |> InterfaceMsg |> dispatch
)
)
QuickAccessButton.create(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting between term and unit is a relatively rare usecase. I think it is better to keep the quicka ccess buttons for common use cases.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Etschbeijer Etschbeijer marked this pull request as ready for review August 8, 2024 12:35
@Etschbeijer Etschbeijer requested a review from HLWeil August 11, 2024 14:43
@Etschbeijer
Copy link
Collaborator Author

The goal of this feature is the ability to convert building blocks.
You can convert terms into units and units into terms.
Additionally, you can also convert data into free text and free text into data.
You cannot convert input- and outpunt columns.

@Etschbeijer
Copy link
Collaborator Author

When you have selected a part of a building block in your table, you can klick on refresh. It will show you the type of building block you have chosen, e.g. Term. When it is convertible, you can click on "Convert XY to YX", converting the building block.
You do not have to click on refresh, you can directly click on "Convert XY to YX" and the button will be updated then.

@@ -97,12 +88,11 @@ let addBuildingBlockComponent (model:Model) (dispatch:Messages.Msg -> unit) =
mainFunctionContainer [
SearchComponent.Main model dispatch
]
if model.PersistentStorageState.Host.IsSome && model.PersistentStorageState.Host.Value = Swatehost.Excel then
// Input forms, etc related to add building block.
Bulma.label "Convert existing cell types."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe write "Convert existing Building Block" instead?

Users might be more familiar with that concept.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Etschbeijer Etschbeijer requested a review from HLWeil August 12, 2024 14:05
@Etschbeijer
Copy link
Collaborator Author

You can convert different building blocks with the implementation of this feature but the kind of building block you can convert to depends on the building block type.
You can check what type your current building block has by clicking on the "Refresh" button in the building block in the excel-swate-nav-bar.
grafik

@Etschbeijer
Copy link
Collaborator Author

Etschbeijer commented Aug 13, 2024

You can click the "Convert" button below the "Refresh" button to convert the currently selected building block into the building block type shown behind the button.
grafik

When you have selected another building block since you have selected the "Refresh" button, the buttons are not automatically updated. You can still convert your selected building block by pressen the "Convert" button, it will be updated then and show you what the building block used to be before you updated it.

@Etschbeijer Etschbeijer merged commit 38e50f9 into developer Aug 13, 2024
@Freymaurer Freymaurer deleted the Feature_Excel_UpdateTermToUnit branch October 28, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants