-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature excel update term to unit #502
Conversation
@@ -36,6 +36,17 @@ let private shortCutIconList model dispatch = | |||
SpreadsheetInterface.CreateAnnotationTable ctrl |> InterfaceMsg |> dispatch | |||
) | |||
) | |||
QuickAccessButton.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converting between term and unit is a relatively rare usecase. I think it is better to keep the quicka ccess buttons for common use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
The goal of this feature is the ability to convert building blocks. |
When you have selected a part of a building block in your table, you can klick on refresh. It will show you the type of building block you have chosen, e.g. Term. When it is convertible, you can click on "Convert XY to YX", converting the building block. |
@@ -97,12 +88,11 @@ let addBuildingBlockComponent (model:Model) (dispatch:Messages.Msg -> unit) = | |||
mainFunctionContainer [ | |||
SearchComponent.Main model dispatch | |||
] | |||
if model.PersistentStorageState.Host.IsSome && model.PersistentStorageState.Host.Value = Swatehost.Excel then | |||
// Input forms, etc related to add building block. | |||
Bulma.label "Convert existing cell types." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe write "Convert existing Building Block" instead?
Users might be more familiar with that concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Closses Issue #454