Debug excel enable conversion of data and free text columns of input / output #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
requested changes
Oct 29, 2024
| @@ -1791,6 +1833,43 @@ let addBuildingBlockAt (excelIndex: int) (newBB: CompositeColumn) (table: Table) | |||
| |> List.iteri (fun ci header -> ExcelHelper.addColumnAndRows (float (excelIndex + ci)) table header bodyValues.[ci] |> ignore) | |||
| } | |||
|
|
|||
| type BodyCellType = | |||
There was a problem hiding this comment.
This type will be added to Shared as CompositeCellDiscriminate in my pr #549
There was a problem hiding this comment.
keep it here and add a [<System.Obsolete("Replace with Shared CompositeCellDiscriminate")>]
Freymaurer
requested changes
Oct 29, 2024
Freymaurer
reviewed
Oct 29, 2024
|
|
||
| return | ||
| match cellType with | ||
| | Some CompositeCellDiscriminate.Unitized -> Some CompositeCellDiscriminate.Term |
There was a problem hiding this comment.
This function must be reworked.
Here is what you do as far as i understand it:
goal: Return valid celltypes for conversion based on cellType
- get active table
- try parse to arctable, then take
.Valuewithout error handling - get selected main column
- check if valid conversion
BUT;
- if
cellTypeis term return unitized without any checking against the selected building block - Similiar for
cellType= Data
There was a problem hiding this comment.
fixed (hopefully)
Freymaurer
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes of smaller problems e.g. column sizes adapt correctly now, when a template is added or building block is deleted
Main problem could not be fully solved, requires fix in ARCtrl