Enable selection of terms to import into excel #584

Etschbeijer · 2024-11-27T15:42:04Z

Closes Issue #425

…son files

Etschbeijer · 2024-12-03T10:57:07Z

Base view of template select

Etschbeijer · 2024-12-03T10:57:49Z

Select template view

Etschbeijer · 2024-12-03T10:58:25Z

Selected template view

Etschbeijer · 2024-12-03T10:59:04Z

Etschbeijer · 2024-12-03T10:59:38Z

Etschbeijer · 2024-12-03T11:00:03Z

Etschbeijer · 2024-12-03T11:00:33Z

Freymaurer · 2024-12-03T13:11:48Z

src/Client/Client.fable-temp.csproj

delete this file

Freymaurer · 2024-12-03T13:13:10Z

src/Client/Modals/SelectiveTemplateFromDB.fs

@@ -0,0 +1,104 @@
+namespace Modals.Template


This is the only file in this exact namespace. Not required therefore.

Freymaurer · 2024-12-03T13:13:20Z

src/Client/Modals/SelectiveImportModal.fs

@@ -1,77 +1,24 @@
-namespace Modals
+namespace Modals.Import


This is the only file in this exact namespace. Not required therefore.

Freymaurer · 2024-12-03T13:14:02Z

src/Client/Modals/SelectiveTemplateFromDB.fs

+            prop.children children
+        ]
+
+    static member toProtocolSearchElement (model: Model) dispatch =


elements PascalCase

Freymaurer · 2024-12-03T13:14:13Z

src/Client/Modals/SelectiveTemplateFromDB.fs

+        ]
+
+    [<ReactComponent>]
+    static member displaySelectedProtocolElements (model: Model, selectionInformation: SelectedColumns, setSelectedColumns: SelectedColumns -> unit, dispatch, ?hasIcon: bool) =


elements PascalCase

Freymaurer · 2024-12-03T13:17:17Z

src/Client/Modals/ModalElements.fs

+            prop.text (string targetselector)
+        ]
+
+    static member RadioPluginsBox(boxName, icon, importType: TableJoinOptions, radioData: (TableJoinOptions * string)[], setImportType: TableJoinOptions -> unit) =


This is way to specialized to be in this namespace

Freymaurer · 2024-12-03T13:17:48Z

src/Client/Modals/ModalElements.fs

+            ]
+        ])
+
+    static member checkBox(columns: CompositeColumn [], index, selectionInformation: SelectedColumns, setSelectedColumns: SelectedColumns -> unit) =


This is way to specialized to be in this namespace and the name is too broad for what it does.

Freymaurer · 2024-12-03T13:18:01Z

src/Client/Modals/ModalElements.fs

+            ]
+        ]
+
+    static member TableWithImportColumnCheckboxes(table: ArcTable, ?selectionInformation: SelectedColumns, ?setSelectedColumns: SelectedColumns -> unit) =


Too specialized to be in this namespace

Freymaurer · 2024-12-03T13:18:26Z

src/Client/Modals/ModalElements.fs

@@ -0,0 +1,183 @@
+module Modals.ModalElements


namespace Modals
...

type ModalElements =

...

Freymaurer · 2024-12-03T13:20:58Z

src/Shared/DTOs/SelectedColumnsModalDto.fs

This will never leave frontend, don't call it DTO and put it in Shared

Correct me if i am wrong with the first assumption

Freymaurer · 2024-12-03T15:37:44Z

src/Client/Modals/ModalElements.fs

@@ -14,6 +14,20 @@ open Fable.React.Helpers

 type ModalElements =

+    static member LogicContainer (children: ReactElement list) =


Move to GenericComponents.fs

Now that i think about it. Why do you need this in a modal? this should only be used for sidebar logic groups?

I grouped all elements that were used by SeletiveTemplateFromDB.fs and SelectiveImporModal.fs into the ModalElements.fs.
Origininally I rebuild the whole template selection as a modal but have undone it.

Freymaurer · 2024-12-03T15:39:26Z

src/Client/States/SelectedColumns.fs

@@ -1,4 +1,4 @@
-module Shared.DTOs.SelectedColumnsModalDto
+module SelectedColumns


This is not a state either. Move to specific module in Types.fs

Freymaurer · 2024-12-11T10:16:12Z

This seems like a ui issue:

is this horizontally scrollable?

Etschbeijer · 2024-12-11T11:06:54Z

This seems like a ui issue:

is this horizontally scrollable?

It is, when you click on it, the scrollbar appears:

Freymaurer · 2024-12-16T12:50:37Z

src/Client/MainComponents/Widgets.fs

                Html.div [
                    prop.style [style.maxHeight (length.px 350); style.overflow.auto]
                    prop.children [
-                        Protocol.TemplateFromDB.displaySelectedProtocolEle model dispatch
+                        SidebarComponents.SidebarLayout.LogicContainer [


No LogicContainers in Widgets :'D

Etschbeijer added 5 commits November 27, 2024 16:41

Enable selection of terms to import into excel

bffed7f

Fix error in swate alpha

2aa0ddf

Move basic modal element creation methods into separat file

b179a4a

Replace existing TemplateFromDB with Modal

b46fc28

Add usage of selected columns to swate alpha

04a2cb7

Etschbeijer marked this pull request as ready for review November 29, 2024 10:40

Etschbeijer requested a review from Freymaurer November 29, 2024 12:38

Adapt box layout

12d4d78

Etschbeijer self-assigned this Dec 3, 2024

Etschbeijer added 4 commits December 3, 2024 09:57

Enable column selection and import type selection for templates and j…

450cda8

…son files

update layout

c2064a5

Improve layout by adding gaps

4d11c9a

Adapted Cehckbox height

2cf7798

Freymaurer requested changes Dec 3, 2024

View reviewed changes

Etschbeijer added 4 commits December 3, 2024 15:05

Apply review changes

ace120f

Implemente review changes

849b155

Implemented review suggestions

869ade6

Implement review changes

ca0a1d4

Etschbeijer requested a review from Freymaurer December 3, 2024 14:26

Freymaurer requested changes Dec 3, 2024

View reviewed changes

Implement review changes

6ddefa4

Etschbeijer requested a review from Freymaurer December 3, 2024 19:19

Implement review changes

5feb2b1

Etschbeijer added 2 commits December 4, 2024 10:19

Enable usage of selectedColumns in swate alpha

9cf7d21

Enable naming of radioGroup to enable usage in swate alpha

95dcf24

Freymaurer approved these changes Dec 16, 2024

View reviewed changes

Freymaurer merged commit 8396611 into main Dec 16, 2024
2 checks passed

		@@ -14,6 +14,20 @@ open Fable.React.Helpers

		type ModalElements =

		static member LogicContainer (children: ReactElement list) =

		@@ -1,4 +1,4 @@
		module Shared.DTOs.SelectedColumnsModalDto
		module SelectedColumns

Enable selection of terms to import into excel #584

Enable selection of terms to import into excel #584

Conversation

Etschbeijer commented Nov 27, 2024 • edited Loading

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Etschbeijer commented Dec 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Freymaurer commented Dec 11, 2024

Etschbeijer commented Dec 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Etschbeijer commented Nov 27, 2024 •

edited

Loading