-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.32.0 #1133
Release 1.32.0 #1133
Conversation
The version bump shouldn't be part of this should it? Which of those commits do you see as being tagged as 1.32.0? |
This commit can be excluded from the pull request, but it should still be added shortly after the release anyway.
|
CHANGES
Outdated
Changes with Unit 1.32.0 26 Feb 2024 | ||
|
||
*) Feature: conditional access logging. | ||
|
||
*) Feature: $request_id variable contains a string that is formed using | ||
random data and can be used as a unique request identifier. | ||
|
||
*) Feature: Ruby response field arrays. | ||
|
||
*) Bugfix: "uidmap" and "gidmap" isolation options validation. | ||
|
||
*) Bugfix: HTTP header field value encoding could be misinterpreted in | ||
Python module. | ||
|
||
*) Bugfix: http.createServer() now accepts "options" argument introduced | ||
in Node.js v9.6.0, v8.12.0. | ||
|
||
*) Bugfix: ServerRequest.flushHeaders() implemented in Node.js module to | ||
make it compatible with Next.js. | ||
|
||
*) Bugfix: ServerRequest.httpVersion variable format in Node.js module. | ||
|
||
*) Bugfix: correct environment variables in Go module for macOS/arm64 | ||
systems. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will edit this one once changes pushed.
Also going to update Dockerfiles if #1131 gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that should get merged.
CHANGES
Outdated
@@ -1,4 +1,30 @@ | |||
|
|||
Changes with Unit 1.32.0 26 Feb 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder comment: the 26 Feb date may change by a few days. Need to ensure it doesn't conflict with any dates on the internal release calendar. 27th and 29th look free right now; will coordinate with release management folks to lock in a date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's aim for 27 Feb 2024 here and in the changes.xml
Currently missing changelog entries from my side...
|
8a8b28d
to
12f3db2
Compare
Rebased, updated
|
12f3db2
to
80e48e5
Compare
One more forgotten change:
|
On Wed, 21 Feb 2024 06:18:40 -0800 andrey-zelenkov ***@***.***> wrote:
@andrey-zelenkov commented on this pull request.
> + *) Bugfix: trying to serve static files over a certain size could lead
+ to error.
Ok. What do you think about this alternative:
`Bugfix: serving static files from a network filesystem could lead to error.`
Works for me...
|
80e48e5
to
dc70957
Compare
Rebased and updated (+ regenerated) changes. Also corrected wording:
|
I wonder if it's worth mentioning these two patches of Alex's in the changelog?
|
I don't think it worth to mention since this is more of a typo. I doubt that anyone seriously tried to use a non-integer number of processes.
If I understand it correctly then this one actually worth to mention. Will add something like |
dc70957
to
523b1b0
Compare
Done:
|
The abstract socket name corruption was... complex... The simplest I could put it would be "... the abstract UNIX socket name could be corrupted during configuration validation..." Specifically this kind of config would trigger it "upstreams": {
"u": {
"servers": {
"unix:@abstract": {}
}
}
} due to calling nxt_sockaddr_unix_parse() twice... See this thread starting here for the gory details. |
523b1b0
to
f5b84a3
Compare
Rebased and reworded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy enough with where things are, but I think we can better describe what our changes actually do / mean. A few suggestions below.
docs/changes.xml
Outdated
|
||
|
||
<changes apply="unit" ver="1.32.0" rev="1" | ||
date="2024-02-27" time="18:00:00 +0300" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Why UTC+3? Is that a nod to when we still had the Moscow office?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied from previous changes. Happy to set any UTC here (can suggest i.e. +0000
)
docs/changes.xml
Outdated
<para> | ||
http.createServer() now accepts "options" argument introduced in Node.js v9.6.0, v8.12.0. | ||
WebAssembly WASI 0.2.0 Component Model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebAssembly WASI 0.2.0 Component Model. | |
Support for WebAssembly Components using WASI interfaces defined in wasi:http/proxy@0.2.0. |
docs/changes.xml
Outdated
packager="Nginx Packaging <[email protected]>"> | ||
<change type="bugfix"> | ||
<para> | ||
correct environment variables in Go module for macOS/arm64 systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct environment variables in Go module for macOS/arm64 systems. | |
Go module now sets environment variables necessary for building on macOS/arm64 systems. |
docs/changes.xml
Outdated
@@ -97,13 +187,23 @@ ServerRequest.httpVersion variable format in Node.js module. | |||
</para> | |||
</change> | |||
|
|||
<change type="bugfix"> | |||
<para> | |||
Node.js module name rules, notable for Nuxt applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js module name rules, notable for Nuxt applications. | |
Node.js module now handles standard library imports prefixed with "node:", making it possible to run newer Nuxt applications, among others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word "now" seems redundant here and elsewhere. I would prefer to get rid of it wherever it already exists, instead of spreading it. All other changes look good, I'll add them in a few hours. Thanks!
docs/changes.xml
Outdated
http.createServer() now accepts "options" argument introduced in Node.js v9.6.0, | ||
v8.12.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http.createServer() now accepts "options" argument introduced in Node.js v9.6.0, | |
v8.12.0. | |
Node.js http.createServer() now accepts and ignores the "options" argument, improving compatibility with strapi applications, among others. |
docs/changes.xml
Outdated
</para> | ||
</change> | ||
|
||
<change type="feature"> | ||
<para> | ||
bytearray in response body for ASGI applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytearray in response body for ASGI applications. | |
Python now supports bytearray response bodies for ASGI applications. |
docs/changes.xml
Outdated
|
||
<change type="feature"> | ||
<para> | ||
Ruby response field arrays. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby response field arrays. | |
Ruby now supports arrays in response headers, improving compatibility with Rack v3.0. |
On Mon, 26 Feb 2024 09:42:08 -0800 andrey-zelenkov ***@***.***> wrote:
@andrey-zelenkov commented on this pull request.
> @@ -53,9 +85,17 @@ NGINX Unit updated to 1.32.0.
</para>
</change>
-<change type="bugfix">
+
+</changes>
+
+
+<changes apply="unit" ver="1.32.0" rev="1"
+ date="2024-02-27" time="18:00:00 +0300"
I just copied from previous changes. Happy to set any UTC here (can suggest i.e. `+0000`)
Yes, no reason not to just use UTC...
|
f5b84a3
to
ccbed6c
Compare
Rebased and improved wording in
|
I'm happy enough with where things are. Thanks! |
|
1 similar comment
|
Good morning @Juan48302 . Thanks for reaching out but we are not adding all fixes / refactoring to the CHANGES document.
|
@tippexs Those comments look like spam... that's a comment of mine that is being quoted... |
Reported |
No description provided.