Entrypoint Fixes #257
Open
Entrypoint Fixes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix exec check on .envsh files
* work with /usr/bin/env rather than sh/bash directly
* chang `$VAR` to `${VAR}` for better read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
/usr/bin/env shrather than/bin/shdirectly$VARto${VAR}for better readChecklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument./update.shand ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & DockerfilesREADMEfor more details)README)