Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spectator): support defer block behavior #641

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

profanis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

stackblitz bot commented Feb 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@profanis profanis requested a review from NetanelBasal March 2, 2024 14:13
Copy link
Member

@NetanelBasal NetanelBasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I've added some comments, let me know what you think. It's also important to update the README after you done so that users will know about this great feature.

projects/spectator/src/lib/spectator/spectator.ts Outdated Show resolved Hide resolved
projects/spectator/src/lib/spectator/spectator.ts Outdated Show resolved Hide resolved
projects/spectator/test/defer-block.spec.ts Show resolved Hide resolved
@profanis profanis requested a review from NetanelBasal March 3, 2024 16:11
@profanis profanis force-pushed the feat/support-defer-block branch from a871435 to bc19e4b Compare March 4, 2024 10:54
@NetanelBasal NetanelBasal merged commit 030ad64 into ngneat:master Mar 4, 2024
3 checks passed
@NetanelBasal
Copy link
Member

Thanks, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants