-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion of changes to matcher.py including Barnes averaging #55
base: master
Are you sure you want to change the base?
Conversation
Added radar timestamp for each matched instance.
Example notebook using radar matching enhancements.
Further radar matching enhancements
@@ -1210,6 +1288,7 @@ def near_neighbor_tunnel(self, verbose=False, timeit=True): | |||
ind1d.append(prind1d) | |||
|
|||
for field in pr.fields.keys(): | |||
# prdata[field]['data'].flat[indt[0]] = \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to retain this commented out field?
distance.append(prdistance) | ||
ind1d.append(prind1d) | ||
|
||
for field in pr.fields.keys(): | ||
prdata[field]['data'][indt[0]] = dfield[field][prind1d] | ||
if Barnes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice addition @swnesbitt
Could you either add |
@@ -1537,7 +1638,7 @@ class MatchData(object): | |||
def __init__(self, flight, data, distance_to_point=None, | |||
indices_1d=None, indices_nd=None, | |||
start_time=None, end_time=None, | |||
ac_rng=None, ac_az=None, ac_elev=None): | |||
ac_rng=None, ac_az=None, ac_elev=None, matchinfo=None): | |||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a short docstring for matchinfo
to describe usage?
@@ -23,6 +23,7 @@ | |||
import simplekml | |||
except: | |||
raise ValueError("This module requires installation of simplekml...") | |||
# return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this return needs to be here as it's an import test. Commented out, but maybe we should remove to clear up any confusion later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you found these kmz writers to be useful?
If you want, add @joefinlon to the contributors list (and anyone else). Otherwise, I can do that when I assign a DOI after this PR. |
This fork includes Barnes averaging around the aircraft position in the radar matching. Testing by @joefinlon.