Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move focus on enter regardless cell editable #1974

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed to start editing in the current cell when the enter key is pressed in a cell that has been edited while using the moveDirectionOnEnter option.

As-Is

To-Be


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma merged commit 4724596 into master Oct 27, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/enter-edit branch October 27, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants