Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate on specific rows #1984

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Added the ability to validate only for certain specified rows.

Passing an array of rowKeys as an argument to the validate API will validate only those rows that correspond to the given rowKeys. But validations that should be performed on all rows, such as unique, may not work correctly.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Comment on lines -8 to -9
// @TODO: find more practical way to make observable
createObservableData(store, true);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일전에 Tree 데이터에 대해 validation이 올바르게 동작하지 않는 이슈를 해결하기 위해 14-18 라인을 추가했는데, 삭제한 코드와 중복된 동작을 수행하므로 제거했습니다.

@jajugoguma jajugoguma requested a review from jwlee1108 November 16, 2023 01:22
@jajugoguma jajugoguma merged commit 2cd5e70 into master Nov 16, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the feat/validate-on-specific-rows branch November 16, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants