Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finish editing when type enter from last cell when using moveDirectionOnEnter #2007

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed an issue where typing Enter in the last cell (when there are no more cells to move) would not complete the edit when using the moveDirectionOnEnter option.

As-Is

To-Be

Fixed an issue where typing Enter in the last cell (when there are no more cells to move) would not complete the edit when using the moveDirectionOnEnter option.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma self-assigned this Jan 4, 2024
Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 잘 동작하네요.

Copy link

@sunyoungBae sunyoungBae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 고생하셨습니다!

@jajugoguma jajugoguma merged commit 285f7ae into master Jan 10, 2024
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/finish-edit-on-last-cell branch January 10, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants