docs / fix global default

nick42d · Dec 4, 2024 · b582c33 · b582c33
1 parent b9e842f
commit b582c33
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/youtui/src/app/component/actionhandler.rs b/youtui/src/app/component/actionhandler.rs
@@ -4,6 +4,7 @@ use crate::{
 };
 use async_callback_manager::AsyncTask;
 use crossterm::event::{Event, KeyCode, KeyEvent, KeyModifiers, MouseEvent};
+use itertools::Itertools;
 use std::{borrow::Cow, collections::BTreeMap};
 use tracing::warn;
 use ytmapi_rs::common::SearchSuggestion;

diff --git a/youtui/src/app/keycommand.rs b/youtui/src/app/keycommand.rs
@@ -27,7 +27,9 @@ pub struct Keybind {
     pub modifiers: KeyModifiers,
 }
 // Since KeyCode and KeyModifiers derive PartialOrd, it's safe to implement this
-// as per below. TODO: PR upstream
+// as per below.
+//
+// Upstream PR that would allow derive(Ord): https://github.com/crossterm-rs/crossterm/pull/951
 #[allow(clippy::derive_ord_xor_partial_ord)]
 impl Ord for Keybind {
     fn cmp(&self, other: &Self) -> std::cmp::Ordering {

diff --git a/youtui/src/config/keybinds.rs b/youtui/src/config/keybinds.rs
@@ -407,7 +407,7 @@ fn default_global_keybinds() -> BTreeMap<Keybind, KeyActionTree<AppAction>> {
         ),
         (
             Keybind::new_unmodified(crossterm::event::KeyCode::Char(' ')),
-            KeyActionTree::new_key_defaulted(AppAction::Pause),
+            KeyActionTree::new_key_with_visibility(AppAction::Pause, CommandVisibility::Global),
         ),
         (
             Keybind::new(crossterm::event::KeyCode::Char('c'), KeyModifiers::CONTROL),