Manual Skia roll from 79a7b95e32fe to 0aec6f7bfbc8 (flutter/engine#57134

) skia-flutter-autoroll Member [skia-flutter-autoroll](https://github.com/skia-flutter-autoroll) commented [1 hour ago](flutter/engine#57131 (comment)) https://skia.googlesource.com/skia.git/+log/79a7b95e32fe..0aec6f7bfbc8 2024-12-11 [[email protected]](mailto:[email protected]) [graphite] Force ordered recordings in nanobench. 2024-12-11 [[email protected]](mailto:[email protected]) [graphite] Rename snippet requirement flag to more clearly express purpose 2024-12-11 [[email protected]](mailto:[email protected]) Roll Skia Infra from a42d0274444b to 0849df86a686 (7 revisions) 2024-12-11 [[email protected]](mailto:[email protected]) Revert "Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec""" 2024-12-11 [[email protected]](mailto:[email protected]) Clamp index values in SkVertices factories 2024-12-11 [[email protected]](mailto:[email protected]) Manual roll vulkan-deps from b5e5616193ec to 769bd5140c26 (8 revisions) 2024-12-11 [[email protected]](mailto:[email protected]) Manual roll Dawn from 052be48b9a1a to 01d91c0571a2 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [[email protected]](mailto:[email protected]),[[email protected]](mailto:[email protected]),[[email protected]](mailto:[email protected]) on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 · Dec 12, 2024 · b6064c9 · b6064c9
1 parent 6aeeb64
commit b6064c9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/DEPS b/DEPS
@@ -14,7 +14,7 @@ vars = {
   'flutter_git': 'https://flutter.googlesource.com',
   'skia_git': 'https://skia.googlesource.com',
   'llvm_git': 'https://llvm.googlesource.com',
-  'skia_revision': '79a7b95e32fe945a1424e596586d616b39cf023d',
+  'skia_revision': '0aec6f7bfbc84b47f9040afe1e534d70cd3145c3',
 
   # WARNING: DO NOT EDIT canvaskit_cipd_instance MANUALLY
   # See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.

diff --git a/engine/src/flutter/ci/licenses_golden/licenses_skia b/engine/src/flutter/ci/licenses_golden/licenses_skia
@@ -1,4 +1,4 @@
-Signature: e99672bef53628139c48a8b95d3e04de
+Signature: 00978b4081cddc5274c012d30c40dd50
 
 ====================================================================================================
 LIBRARY: etc1

diff --git a/engine/src/flutter/display_list/skia/dl_sk_conversions_unittests.cc b/engine/src/flutter/display_list/skia/dl_sk_conversions_unittests.cc
@@ -198,12 +198,12 @@ TEST(DisplayListSkConversions, ConvertWithZeroAndNegativeVerticesAndIndices) {
   std::shared_ptr<DlVertices> vertices1 = DlVertices::Make(
       DlVertexMode::kTriangles, 0, nullptr, nullptr, nullptr, 0, nullptr);
   EXPECT_NE(vertices1, nullptr);
-  EXPECT_NE(ToSk(vertices1), nullptr);
+  EXPECT_EQ(ToSk(vertices1), nullptr);
 
   std::shared_ptr<DlVertices> vertices2 = DlVertices::Make(
       DlVertexMode::kTriangles, -1, nullptr, nullptr, nullptr, -1, nullptr);
   EXPECT_NE(vertices2, nullptr);
-  EXPECT_NE(ToSk(vertices2), nullptr);
+  EXPECT_EQ(ToSk(vertices2), nullptr);
 }
 
 TEST(DisplayListVertices, ConvertWithZeroAndNegativeVerticesAndIndices) {
@@ -212,14 +212,14 @@ TEST(DisplayListVertices, ConvertWithZeroAndNegativeVerticesAndIndices) {
   EXPECT_TRUE(builder1.is_valid());
   std::shared_ptr<DlVertices> vertices1 = builder1.build();
   EXPECT_NE(vertices1, nullptr);
-  EXPECT_NE(ToSk(vertices1), nullptr);
+  EXPECT_EQ(ToSk(vertices1), nullptr);
 
   DlVertices::Builder builder2(DlVertexMode::kTriangles, -1,
                                DlVertices::Builder::kNone, -1);
   EXPECT_TRUE(builder2.is_valid());
   std::shared_ptr<DlVertices> vertices2 = builder2.build();
   EXPECT_NE(vertices2, nullptr);
-  EXPECT_NE(ToSk(vertices2), nullptr);
+  EXPECT_EQ(ToSk(vertices2), nullptr);
 }
 
 TEST(DisplayListColorSource, ConvertRuntimeEffect) {

diff --git a/engine/src/flutter/impeller/renderer/backend/gles/test/reactor_unittests.cc b/engine/src/flutter/impeller/renderer/backend/gles/test/reactor_unittests.cc
@@ -95,7 +95,7 @@ TEST(ReactorGLES, UntrackedHandle) {
   EXPECT_TRUE(reactor->React());
 }
 
-TEST(ReactorGLES, NameUntrackedHandle) {
+TEST(ReactorGLES, DISABLED_NameUntrackedHandle) {
   auto mock_gles_impl = std::make_unique<MockGLESImpl>();
 
   EXPECT_CALL(*mock_gles_impl, GenTextures(1, _))