Switch to 10.8 to use recent Qt on mac #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds failed on Mac because Qt 5.10 gets installed with brew.
This mac ci issue has two possible fixes. Either setting QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.8 and building with Qt 5.10 or changing ci script to get Qt 5.6 from brew and thus end up using the same Qt version for all ci builds. I was unable to pin exact Qt version on mac, so dropping 10.7 support might be the easiest solution.
p.s.
In my opinion Qt 5.9 should be used on all ci builds as it is current LTS version.