-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eagerly fill LogFilteredData::filteredItemsCache_ #224
Open
gin-ahirsch
wants to merge
6
commits into
nickbnf:master
Choose a base branch
from
gin-ahirsch:eager-filtered-items-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Eagerly fill LogFilteredData::filteredItemsCache_ #224
gin-ahirsch
wants to merge
6
commits into
nickbnf:master
from
gin-ahirsch:eager-filtered-items-cache
+279
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line numbers will be int::max() if the iterators are at the end, so we don't need to check the iterators here.
gin-ahirsch
force-pushed
the
eager-filtered-items-cache
branch
from
June 21, 2018 08:04
534fc4c
to
3ed384d
Compare
I fixed some issues with the last commit. It actually builds now :) |
gin-ahirsch
force-pushed
the
eager-filtered-items-cache
branch
from
June 21, 2018 09:39
3ed384d
to
4d38f64
Compare
and progressively fill/remove items instead of completely regenerating the whole cache.
by passing in a guess for the index.
gin-ahirsch
force-pushed
the
eager-filtered-items-cache
branch
from
August 10, 2018 10:30
4d38f64
to
70538f4
Compare
Rebased with the following diff:
|
gin-ahirsch
force-pushed
the
eager-filtered-items-cache
branch
from
March 4, 2019 15:50
caf0e7b
to
b49a6a8
Compare
gin-ahirsch
force-pushed
the
eager-filtered-items-cache
branch
from
March 4, 2019 16:16
b49a6a8
to
cc302f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.