Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown issue resolved!! #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NilayGandhi29
Copy link

Issue #5

Changed the intelCore.h arguments to support the newer versions of the QEMU.

Shutdown issue solved!!
Changed the intelCore.h file to support newer versions of the QEMU which were causing problems.
@nieklinnenbank
Copy link
Owner

Hi,

Thanks for solving! Indeed this works on newer Qemu versions.
Could you please update your pull request by:

  • squashing the two commit into 1 commit (now it are two commits)
  • provide a single line comment in the commit in the following format:
    path/to/the/file/or/module: single sentence describing what changed
    so for your change, it would be for example:
    lib/libarch/intel/IntelCore: update cpu_shutdown() to support newer Qemu versions
  • please remove the '#include "Endian.h" line, it is not required for this change

Once updated, i will merge your pull request.
Thanks,
Niek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants