Warn instead of fail on invaild paths in tarball #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build of Go 1.11.5 has some harmless build artifacts in the tarball; emit a warning while iterating over those, rather than failing completely. See https://groups.google.com/d/msg/golang-announce/mVeX35iXuSw/HxYXaBnYEAAJ
|
@gwatts thx for your patch :)! I implemented it a bit differently in our fork of godeb, to not shadow potential errors in the future with warning messages with and an eye towards automated CI systems. #40 - ( To not create warnings which could be overseen in automated CI pipelines, i created a patch to explicitely ignore the superfluous artifacts included in go1.11.5 release tarballs instead of just downgrading all errors from unknown content to warnings. ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of Go 1.11.5 has some harmless build artifacts in the tarball;
emit a warning while iterating over those, rather than failing
completely.
See
https://groups.google.com/d/msg/golang-announce/mVeX35iXuSw/HxYXaBnYEAAJ