-
Notifications
You must be signed in to change notification settings - Fork 71.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a color option to the Clock View values and arrows #8236
Open
JaredDRobbins
wants to merge
62
commits into
nightscout:dev
Choose a base branch
from
JaredDRobbins:master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add black background with colored sgv/arrow option
add "Black w/ Color" option to Background type picker
update "Black w/ Color" to set element "color" instead of "background-color"
arrow element style
default clock view config
add width to arrow
remove arrow width
add colored trend arrows
hex arrow colors
colored arrow width
arrow - display:flex;
original-tab delimited
original-tab delimited
original-tab delimited
add color checkboxes
pre-size line breaks
config-form background/opacity
clocklink:active
add size_color class
add size_color div wrappers
replace <p> with <div>
p > div
div back to p
p < div
size_color align
trying divs again
trying divs again
#config-form form > div
flip button/attribute positions
button width
.size_color {margin-bottom}
text-stroke
watch color check boxes
input.elmt.click
arrow stroke
arrow width/color
reduce arrow stroke width to 1
change from text stroke to text shadow
arrow stroke width to 3
// classParam = classParam.toLowerCase();
classParam = classParam.toLowerCase();
face = $inner.data('face');
alt cofig row colors
thresholdReached - remove color class
thresholdReached - color class to black
bring trend arrow back after thresholdReached is no loner true
original formatting
2 space indent
2 space indent
2 space indent
2 space indent
text-shadow x 8
increase arrow stroke width to 4
comma first
body color white
ARROW COLOR WHITE
white text/arrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a checkbox to the "Clock view configurator" that will add color to the displayed values/arrows and change the default value color from grey to white.