Update mongo libs from 3.6 to 5 #8314
Conversation
Provide some tests for the profile API.
Add tests for activity API.
bewest
changed the title
|
@MilosKozak Does AAPS send multiple batch items through this interface? If so, it looks like the websocket stuff may still need more work. |
|
There is a list of methods targeted here: Here's an especially relevant section:
|
| Removed API | API to migrate to |
|---|---|
insert(document) |
insertOne(document) |
insert(arrayOfDocuments) |
insertMany(arrayOfDocuments) |
update(filter) |
updateMany(filter) |
remove(filter) |
deleteMany(filter) |
The insert method accepted an array of documents for multi-document inserts and a single document for single-document inserts. insertOne should now be used for single-document inserts and insertMany should be used for multi-document inserts.
I've completed a review of the source tree and and have converted all insert calls into insertOne. If AAPS or something else uses this to modify multiple activities, foods, profiles, or calls dbAdd via websocket with multiple documents, there will probably be issues. Also it's not clear what users are doing with the results from websocket events given to the callback.
Also, for whatever reason, remove(filter) seems to still work...
Tests have been added for areas of the api that were missing.
We need some actual testing with AAPS rigs (different/older versions would be nice as well), multiple looping systems, etc.
Another significant thing to note is that there is now a 15 second delay between entering data and seeing it reappear on the display, likely due to debouncing. We can adjust this based on feedback.
| @@ -405,20 +406,22 @@ function init (env, ctx, server) { | |||
| } | |||
| // if not found create new record | |||
| console.log(LOG_DEDUP + 'Adding new record'); | |||
| ctx.store.collection(collection).insert(data.data, function insertResult (err, doc) { | |||
| ctx.store.collection(collection).insertOne(data.data, function insertResult (err, ops) { | |||
There was a problem hiding this comment.
AAPS folks: do multiple documents come through this interface as an array? Can you provide any examples?
| if (err != null && err.message) { | ||
| console.log('treatments data insertion error: ', err.message); | ||
| return; | ||
| } | ||
|
|
||
| var doc = data.data; |
There was a problem hiding this comment.
Do you have a roadmap or anything around browser support? How much longer will the codebase use var instead of let/const?
Looks like any android/ios device since 2011 should support let/const - there are no vendor-currently-supported os/browser combinations that don't support them.
Maybe the approach could be "use nightscout 15 for old browsers" and do any work on the f/e to support newer testing/frameworks in a nightscout v16 that will only support newer browsers? I think you'll rapidly paint yourself into a corner if "we're not waiting" becomes "we support your ancient devices forever"
Revert a revert to get original pull request back.
This reverts commit 2e65b1d. Try to bring back #8026.