auth: Avoid overlapping permission names

The names have to be unique to correctly apply filtering on project scoped forms.

weblate/auth/data.py

@@ -132,7 +132,7 @@
     # Translators: Permission name
     ("announcement.edit", gettext_noop("Manage announcements")),
     # Translators: Permission name
-    ("memory.edit", gettext_noop("Manage translation memory")),
+    ("memory.manage", gettext_noop("Manage translation memory")),
     # Translators: Permission name
     ("machinery.edit", gettext_noop("Manage machinery")),
     # Translators: Permission name

weblate/auth/permissions.py

@@ -475,7 +475,7 @@ def check_memory_perms(user, permission, memory):
         if memory.user_id == user.id:
             return True
         if memory.project is None:
-            return user.is_superuser
+            return check_permission(user, "memory.manage")
         project = memory.project
     else:
         project = memory

weblate/auth/tests/test_permissions.py

@@ -7,7 +7,12 @@
 from django.test.utils import modify_settings, override_settings
 from django.utils import timezone
 
-from weblate.auth.data import SELECTION_ALL_PROTECTED, SELECTION_ALL_PUBLIC
+from weblate.auth.data import (
+    GLOBAL_PERM_NAMES,
+    PERMISSION_NAMES,
+    SELECTION_ALL_PROTECTED,
+    SELECTION_ALL_PUBLIC,
+)
 from weblate.auth.models import Group, Permission, Role, User
 from weblate.trans.models import Comment, Project
 from weblate.trans.tests.test_views import FixtureTestCase
@@ -24,6 +29,9 @@ def setUp(self):
         )
         self.project.add_user(self.admin, "Administration")
 
+    def test_permission_overlap(self):
+        self.assertEqual(PERMISSION_NAMES & GLOBAL_PERM_NAMES, set())
+
     def test_admin_perm(self):
         self.assertTrue(self.superuser.has_perm("upload.authorship", self.project))
         self.assertTrue(self.admin.has_perm("upload.authorship", self.project))