Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CD action versions and add poetry and npm caching #85

Merged
merged 4 commits into from
May 1, 2024
Merged

Update CD action versions and add poetry and npm caching #85

merged 4 commits into from
May 1, 2024

Conversation

Privat33r-dev
Copy link
Collaborator

No description provided.

@Privat33r-dev Privat33r-dev force-pushed the fix/cd branch 2 times, most recently from e85f18a to 6812e1d Compare April 16, 2024 19:51
@Privat33r-dev
Copy link
Collaborator Author

Privat33r-dev commented Apr 19, 2024 •
edited
Loading

Current state:
Github doesn't let to just update pre-release artifacts, so deletion is required. It feels too hacky, I am working on the solution. However, there are plenty of things that can be improved in the current setup:

Old TODO list

- [ ] Fix: Pre-Release versions not being replaced
- [ ] Skip pre-release build on actual build
- [ ] Update all the action versions to avoid "Node 16" warning
- [ ] Cache poetry

@Privat33r-dev
Copy link
Collaborator Author

Privat33r-dev commented Apr 29, 2024 •
edited
Loading

Upon further discussion in private with the @nikitastupin we decided to split PR in 2 parts: the first would update the CD versions and add caching/cleanup. The other part would introduce pre-release build workflow.

TODO list:

  • Update all the action versions to avoid "Node 16" warning
  • Cache poetry
  • Cache node

Another PRs:

  • Make single source of truth for versioning of Python, Node and other dependencies
  • Make single source of truth for the app versioning (e.g. git tag/file)
  • Cleanup workflows using best practices: too much repetition for poetry setup
  • Cache poetry itself (potential time saving: 10-20 seconds per run)

@Privat33r-dev Privat33r-dev force-pushed the fix/cd branch 11 times, most recently from 6cb21b6 to 9446722 Compare April 30, 2024 00:37
@Privat33r-dev Privat33r-dev changed the title Improve CD Update CD action versions and add poetry and npm caching Apr 30, 2024
@Privat33r-dev Privat33r-dev marked this pull request as ready for review April 30, 2024 10:00
nikitastupin
nikitastupin reviewed Apr 30, 2024
View reviewed changes
Copy link
Owner

@nikitastupin nikitastupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of neat picks otherwise looks good! Thank you!

@Privat33r-dev
Improve CD
a54a1bb 
Update action versions
Add `make_latest` param to version release
Update node version
@Privat33r-dev
CD: add caching, move py and node versions to env
b2bafcd 
`npm ci` instead of `npm install` is more suitable for CI
many minor changes required for caching
@Privat33r-dev
Minor CD refactoring
56a27e5 
Add descriptive names to steps
@Privat33r-dev
Make minor refactoring for CD tests
1e3bf1f 
 - Autoformat
 - Add names to steps
@nikitastupin
Copy link
Owner

Merging! Thank you!

@nikitastupin nikitastupin merged commit 5ad23c4 into nikitastupin:main May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitastupin nikitastupin nikitastupin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Privat33r-dev @nikitastupin