New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue resolving nim executable path when nimble nimDir is defined #86

Merged

jmgomez merged 2 commits into nim-lang:main from scupit:bugfix/unable-to-find-nim-binary

Aug 11, 2024

Contributor

scupit commented Aug 11, 2024

fixes #35

When the result of nimble dump contains nimDir, use nimDir as the initial search path for the nim executable instead of returning the directory itself (which would never be valid).
When searching for an executable (nimsuggest, nimlangserver, etc.), don't use the HOME environment variable on Windows. This was causing issues with node's path resolution functions which don't accept undefined.

scupit added 2 commits

August 10, 2024 18:42


          Fixed extension loading issue during development - don't use HOME env…

f29bc0c

…ironment variable to resolve paths to binaries on Windows.


          Fixed nim executable loading bug - search for nim executable in the n…

294f378

…imble nimDir instead of returning the nimDir directly

jmgomez merged commit d7e7c54 into nim-lang:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet