[#197] Keep the template project up to date with new configurations, versions from the Flutter starter project #201

luongvo · 2023-05-22T16:52:26Z

Solves Keep the template project up to date with new configurations, versions from the Flutter starter project #197

What happened 👀

Android
- Update Kotlin to 1.7.10
- Update Gradle to 7.3
- Update Manifest structure
- io.flutter.embedding.android.SplashScreenDrawable is now deprecated
iOS
- Update default app icons
- MinimumOSVersion to 11
- Fix: build configurations for both production and staging schemes. Now we have 4 build configurations for each:
  - Staging Debug
  - Staging Release
  - Production Debug
  - Production Release
- Update project.pbxproj to latest project structure.
Flutter base
- Remove redundant cupertino_icons
- Update some dependencies to the latest versions
- ~~Add useMaterial3: true, to base ThemeData in main.dart~~

Insight 📝

flutter_config does not work with the newest Gradle version. While waiting for the official support, we have to switch to the alternative https://pub.dev/packages/flutter_config_plus ✅ . Updating to flutter_config_plus requires:
- Android's minSdkVersion 21 👉 23
- iOS's MinimumOSVersion to 11
After updating permission_handler: ^10.2.0, we must run this command to let Mason re-generates the bundle file ✅
```
 mason bundle bricks/permission_handler -t dart -o bricks/template/hooks/bundles
```

Proof Of Work 📹

Env	Staging	Production
Android
iOS

bricks/template/__brick__/{{project_name.snakeCase()}}/.gitignore

bricks/template/__brick__/{{project_name.snakeCase()}}/android/app/build.gradle

luongvo · 2023-07-11T11:40:34Z

flutter_config seems back to work properly in version 2.0.2 https://github.com/ByneappLLC/flutter_config/commits/master 🤔

…s not work on the newest Gradle version"

…ermission_handler dependency

luongvo · 2023-07-14T03:28:12Z

@doannimble I answered your concern here.

bricks/template/__brick__/{{project_name.snakeCase()}}/ios/Podfile.lock

doannimble

LGTM now 🚀

chornerman

@luongvo I'm curious do we have a plan to do this with the sample folder? 🤔

luongvo · 2023-07-14T09:20:07Z

@chornerman We have this workflow https://github.com/nimblehq/flutter-templates/blob/develop/.github/workflows/generate_sample.yml. However, I plan to update the sample on each PR instead with this RFC #219 😄

chornerman · 2023-07-14T09:26:11Z

@luongvo I see now, thanks for the explanation 😄

bricks/template/__brick__/{{project_name.snakeCase()}}/lib/main.dart

doannimble · 2023-07-17T04:30:03Z

@luongvo Just a curious question, should we update the pubspec.yaml of sample too? 🤔

luongvo · 2023-07-17T05:11:59Z

@doannimble I have the same answer here, please check it out #201 (comment) 👋

luongvo · 2023-07-17T15:03:00Z

POW is updated (without Material3 enabled).

luongvo · 2023-07-19T02:41:11Z

@manh-t @sleepylee your final reviews are appreciated 🤗

manh-t

LGTM now 🙆‍♂️

luongvo added the type : chore label May 22, 2023

luongvo added this to the 1.8.0 milestone May 22, 2023

luongvo self-assigned this May 22, 2023

luongvo force-pushed the feature/197-update-new-flutter-project-structure branch from 9b2726a to 8185136 Compare May 22, 2023 17:00

luongvo commented May 22, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/.gitignore Show resolved Hide resolved

luongvo commented May 22, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/.gitignore Show resolved Hide resolved

luongvo commented May 22, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/.gitignore Show resolved Hide resolved

luongvo force-pushed the feature/197-update-new-flutter-project-structure branch 3 times, most recently from f7b3d23 to 247beeb Compare May 22, 2023 18:08

luongvo commented May 22, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/android/app/build.gradle Show resolved Hide resolved

luongvo linked an issue May 22, 2023 that may be closed by this pull request

Keep the template project up to date with new configurations, versions from the Flutter starter project #197

Closed

luongvo mentioned this pull request May 23, 2023

[#159] [Generate project with Mason] Generate the new project & keep the generated project in the repository root folder for reference #196

Merged

Base automatically changed from feature/159-generate-sample-project to develop May 23, 2023 03:55

luongvo modified the milestones: 1.8.0, 1.9.0 Jun 2, 2023

luongvo modified the milestones: 1.9.0, 1.10.0 Jul 5, 2023

luongvo force-pushed the feature/197-update-new-flutter-project-structure branch 3 times, most recently from 3f6413b to 0c8c863 Compare July 7, 2023 08:52

luongvo marked this pull request as ready for review July 7, 2023 09:05

luongvo requested review from manh-t, doannimble, markgravity, sleepylee and chornerman as code owners July 7, 2023 09:05

doannimble approved these changes Jul 7, 2023

View reviewed changes

doannimble self-requested a review July 7, 2023 09:25

luongvo force-pushed the feature/197-update-new-flutter-project-structure branch from 4c7039a to 91f3d80 Compare July 7, 2023 09:59

luongvo added 2 commits July 10, 2023 14:46

[#197] Fix: flutter analyze issues after upgrading dio

cfc128b

[#197] Update min Android SDK back to 23

18ba9fa

luongvo force-pushed the feature/197-update-new-flutter-project-structure branch from 7b45227 to 18ba9fa Compare July 10, 2023 07:46

luongvo changed the title ~~[#197] Keep the template project up to date with new configurations, versions from the Flutter started project~~ [#197] Keep the template project up to date with new configurations, versions from the Flutter starter project Jul 10, 2023

luongvo added 2 commits July 13, 2023 17:59

Revert "[#197] Switch to flutter_config_plus while flutter_config doe…

94f5fb1

…s not work on the newest Gradle version"

[#197] Improve: remove unnecessary linebreak when skipping generate p…

3da827a

…ermission_handler dependency

manh-t reviewed Jul 14, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/ios/Podfile.lock Outdated Show resolved Hide resolved

doannimble approved these changes Jul 14, 2023

View reviewed changes

[#197] Update .lock files with non-optional features generated

5f5d1e2

luongvo requested a review from manh-t July 14, 2023 04:24

chornerman reviewed Jul 14, 2023

View reviewed changes

sleepylee reviewed Jul 17, 2023

View reviewed changes

bricks/template/__brick__/{{project_name.snakeCase()}}/lib/main.dart Outdated Show resolved Hide resolved

luongvo mentioned this pull request Jul 17, 2023

Apply Material3 and the new Theming updates #236

Open

[#197] Skip Material3 enabling from this task

108474d

luongvo requested review from sleepylee and chornerman July 17, 2023 11:40

luongvo mentioned this pull request Jul 17, 2023

[#224] Add support for SVG and color assets #231

Merged

3 tasks

markgravity approved these changes Jul 19, 2023

View reviewed changes

kaungkhantsoe approved these changes Jul 19, 2023

View reviewed changes

manh-t approved these changes Jul 19, 2023

View reviewed changes

luongvo merged commit 9b86b3f into develop Jul 19, 2023

luongvo deleted the feature/197-update-new-flutter-project-structure branch July 19, 2023 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#197] Keep the template project up to date with new configurations, versions from the Flutter starter project #201

[#197] Keep the template project up to date with new configurations, versions from the Flutter starter project #201

luongvo commented May 22, 2023 •

edited

Loading

luongvo commented Jul 11, 2023

luongvo commented Jul 14, 2023

doannimble left a comment

chornerman left a comment •

edited

Loading

luongvo commented Jul 14, 2023 •

edited

Loading

chornerman commented Jul 14, 2023

doannimble commented Jul 17, 2023

luongvo commented Jul 17, 2023

luongvo commented Jul 17, 2023

luongvo commented Jul 19, 2023

manh-t left a comment

[#197] Keep the template project up to date with new configurations, versions from the Flutter starter project #201

[#197] Keep the template project up to date with new configurations, versions from the Flutter starter project #201

Conversation

luongvo commented May 22, 2023 • edited Loading

What happened 👀

Insight 📝

Proof Of Work 📹

luongvo commented Jul 11, 2023

luongvo commented Jul 14, 2023

doannimble left a comment

Choose a reason for hiding this comment

chornerman left a comment • edited Loading

Choose a reason for hiding this comment

luongvo commented Jul 14, 2023 • edited Loading

chornerman commented Jul 14, 2023

doannimble commented Jul 17, 2023

luongvo commented Jul 17, 2023

luongvo commented Jul 17, 2023

luongvo commented Jul 19, 2023

manh-t left a comment

Choose a reason for hiding this comment

luongvo commented May 22, 2023 •

edited

Loading

chornerman left a comment •

edited

Loading

luongvo commented Jul 14, 2023 •

edited

Loading