-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrestakingWelcome: implement designer feedback #183
Conversation
Nice! Some minor feedback :)
|
About that, it's actually an intended behavior. If you go back it will pause, if you go next it will have a timer. Comes from the idea that if you go back it's to take your time to read, so it would imo be meaningless to have the timer start again. Unless we implement the mousedown/mouseup feature to pause, but... If I add the Mousedown to pause / Mouseup to continue, then we imo should have something to also hint this behavior, otherwise users may just not know about it and there would be no visible way to pause on a slide, thus lower the user experience. |
This is how the instagram behaviour works, and I'd love to mimick this as much as possible, as it's by now not just a pattern used by instagram but by other apps too and lots of people are able to intuitively use it. That said, I'm okay with not letting the timer run when you go back to a previous step, as long as we introduce the mousedown/mouseup feature. It's a discoverable feature, so no need to hint at it |
557f1a0
to
0d9c8ad
Compare
The "let's go" button disabled style has been updated, and the pause feature implemented while trying to avoid any conflicts with the next/previous arrows as well as the swipe left/right feature on mobile. The branch selector has been updated with the latest state. |
The prestaking welcome page now behave like an “instagram story” or something the like.
0d9c8ad
to
a37a31b
Compare
The prestaking welcome page now behave like an “instagram story” or something the like.