Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the update command with the language #142

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix the update command with the language #142

merged 3 commits into from
Aug 15, 2024

Conversation

gajicdev
Copy link
Contributor

if you do not set the language explicitly, it will always be nil currenlty

Copy link
Contributor

@ctrox ctrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what happened with the github actions (maybe give it a retry first) but the change itself looks good.

@gajicdev
Copy link
Contributor Author

@ctrox yeah not sure, locally the tests pass 🤷

@ctrox
Copy link
Contributor

ctrox commented Aug 15, 2024

@gajicdev I can see that the action actions/setup-go@v5 downloads go 1.23 which just came out. We should pin the version to 1.22 and upgrade it later.

instead of using "stable" we want to pin the minor version to avoid
sudden breaking updates as we experienced with 1.23.
this came up in staticcheck
@gajicdev gajicdev merged commit 6dc848b into main Aug 15, 2024
2 checks passed
@gajicdev gajicdev deleted the fix-update branch August 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants