Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for command-line arguments to prevent browser error pop-ups #146

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add error handling for command-line arguments to prevent browser error pop-ups #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ func main() {
// for the resourcePredictor to use the correct APICluster, we need to
// call parse already. Note that this won't parse the flag for
// completion but it will work for the default and env.
_, _ = parser.Parse(os.Args[1:])
_, err = parser.Parse(os.Args[1:])
if err != nil {
return nil, err
}
// the client for the predictor requires a static token in the client config
// since dynamic exec config seems to break with some shells during completion.
// The exact reason for that is unknown.
Expand Down