Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deploy-job to config create/update #68

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Nov 6, 2023

This makes it possible to configure deploy-jobs with configs.

mono-infra#845

@pawelkuc
Copy link
Contributor

pawelkuc commented Nov 6, 2023

Just wondering if we need to show some deploy-job info (e.g. name of the job if there is a job configured) when we Get deplo.io Project Configuration. For now the get command for config gives us:

"NAME",
"SIZE",
"REPLICAS",
"PORT",
"ENVIRONMENT_VARIABLES",
"AGE",

which is almost everything we store in the Config struct{} minus BasicAuth and DeployJob.

@ctrox
Copy link
Contributor Author

ctrox commented Nov 6, 2023

Just wondering if we need to show some deploy-job info (e.g. name of the job if there is a job configured) when we Get deplo.io Project Configuration.

Was also thinking about that but a deploy-job has 4 different attributes, so adding 4 more columns would make the already wide output incredibly wide 😄

Edit: I guess just showing the name or none if none is configured could work.

@pawelkuc
Copy link
Contributor

pawelkuc commented Nov 6, 2023

Edit: I guess just showing the name or none if none is configured could work.

yeah. I was thinking about this only.

This adds two new columns to the get output of configs:

* BASIC_AUTH=bool
* DEPLOY_JOB=jobName
@ctrox
Copy link
Contributor Author

ctrox commented Nov 6, 2023

@pawelkuc I added a commit, it now looks like this:

$ nctl get config
NAME    SIZE     REPLICAS    PORT    ENVIRONMENT_VARIABLES    BASIC_AUTH    DEPLOY_JOB    AGE
nine    micro    0           8080    <none>                   false         <none>        75d

@pawelkuc
Copy link
Contributor

pawelkuc commented Nov 6, 2023

looks good! thank you 😄

@ctrox ctrox merged commit 06e9542 into main Nov 6, 2023
2 checks passed
@ctrox ctrox deleted the config-deploy-job branch November 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants