fix: ipam interface should check on virtualmachine nil state #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterO2
force-pushed
the
fix_wrong_ipaddress_interface
branch
from
af7e7fa to
77ab597
Compare
thde
force-pushed
the
fix_wrong_ipaddress_interface
branch
from
bd395b5 to
b0b8a9c
Compare
thde
changed the title
thde
previously approved these changes
Oct 28, 2024
n-rodriguez
reviewed
Oct 28, 2024
| @@ -34,7 +34,7 @@ def interface | |||
|
|
|||
| return nil unless interface_data | |||
|
|
|||
| if interface_data.key?('virtual_machine') | |||
| if interface_data.key? ('virtual_machine') && !interface_data['virtual_machine'].nil? | |||
There was a problem hiding this comment.
Be careful of the space between key? and ('virtual_machine')
There was a problem hiding this comment.
I changed the implementation to a, in my opinion, simpler one.
thde
force-pushed
the
fix_wrong_ipaddress_interface
branch
from
b0b8a9c to
46692ca
Compare
thde
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class IpAddress has a function called 'interface' returning a Virtualization or DCIM interface based on the existance of the 'virtual_machine' property. But in case of a DCIM interface this property exists as well, only set to nil. So this nil check has to be added to return the right interface.