Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add missing frozen string literal comment #78

Merged
merged 1 commit into from
Oct 25, 2024
Merged

refactor: add missing frozen string literal comment #78

merged 1 commit into from
Oct 25, 2024

Conversation

n-rodriguez
Copy link
Contributor

No description provided.

@n-rodriguez
Copy link
Contributor Author

ping @thde

@n-rodriguez
Copy link
Contributor Author

@thde you forgot this one 😄

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented Oct 22, 2024 •
edited
Loading

@thde I think you should read this https://gist.github.com/fxn/bf4eed2505c76f4fca03ab48c43adc72 for a better understanding of why this PR

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented Oct 22, 2024 •
edited
Loading

@thde The error in CI has nothing to do with this PR.

This PR revealed a bug in the gem : https://github.com/ninech/netbox-client-ruby/pull/78/files#diff-45ae662d8aec8fb27659072ad06e7830118ef3d5ed4a4df0c0f2f1f812056a1e (in case you missed it)

@thde
Copy link
Member

thde commented Oct 25, 2024

Cache is cleared, but it still shows the same error and seems to pull something.

❯ gh cache list
No caches found in ninech/netbox-client-ruby

As it works in the default branch, this leads me to believe, that Github Actions may associate the cache to your repository. Would you mind trying to clear the caches in your fork?

@n-rodriguez
Copy link
Contributor Author

As it works in the default branch, this leads me to believe, that Github Actions may associate the cache to your repository. Would you mind trying to clear the caches in your fork?

done!

> gh cache list
No caches found in n-rodriguez/netbox-client-ruby

@thde thde force-pushed the wip/frozen-strings branch from 1458d92 to 807c905 Compare October 25, 2024 11:35
@thde thde changed the title Coding style: add missing frozen string literal comment refactor: add missing frozen string literal comment Oct 25, 2024
@thde thde merged commit fcdd272 into ninech:master Oct 25, 2024
12 of 13 checks passed
@n-rodriguez n-rodriguez deleted the wip/frozen-strings branch October 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thde thde thde approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-rodriguez @thde