Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix output order #310

Merged
merged 4 commits into from
Aug 30, 2023
Merged

CI: Fix output order #310

merged 4 commits into from
Aug 30, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Aug 30, 2023

  • sort behavior seemingly changed with the newer circle images
  • updated testing data derivatives formatting should now allow --derivatives pathway to be tested.

Continues #305

@effigies
Copy link
Member

Maybe the simpler thing is to both sort the expected file and the actual file, and then we don't have to worry about updating the order based on what version of coreutils is installed. My local still sorts the old way, which makes updating these a pain.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (131f0d5) 33.28% compared to head (6a38698) 33.28%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   33.28%   33.28%           
=======================================
  Files          55       55           
  Lines        5195     5195           
=======================================
  Hits         1729     1729           
  Misses       3466     3466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd
Copy link
Collaborator Author

mgxd commented Aug 30, 2023

Sounds reasonable enough - I'll let this run through and then push that

@mgxd mgxd marked this pull request as ready for review August 30, 2023 20:02
@mgxd mgxd requested a review from effigies August 30, 2023 20:02
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@effigies effigies merged commit 83576ea into master Aug 30, 2023
6 checks passed
@effigies effigies deleted the ci/fix-outputs branch August 30, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants