feat: Output fsLR meshes on subject surfaces #460
Conversation
effigies
force-pushed
the
enh/fslr_surfs
branch
from
5028f49 to
26ef80d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
===========================================
+ Coverage 63.02% 74.21% +11.19%
===========================================
Files 25 25
Lines 1947 1955 +8
Branches 242 245 +3
===========================================
+ Hits 1227 1451 +224
+ Misses 682 439 -243
- Partials 38 65 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
enh/fslr_surfs
branch
from
26ef80d to
60c7a94
Compare
effigies
force-pushed
the
enh/fslr_surfs
branch
from
60c7a94 to
7e93927
Compare
|
@tsalo Could I bother you for a review? |
There was a problem hiding this comment.
This looks awesome!
The looping in init_resample_surfaces_wf goes a little over my head, but everything looks great.
One question- would it make sense to calculate the inflated and veryinflated surfaces in fsLR space, or would you prefer to leave that to the post-processing workflow?
I don't have a strong preference not to do it, but I also don't want to hold up this feature on my understanding another. Feel free to open a follow-up issue. |
0.17.0 (December 19, 2024)
New feature release in the 0.17.x series.
This release improves handling of datasets where T1w images are not
the primary modality. It also supports the generation of fsLR meshes
on the subject surface with the names:
sub-<label>/anat/sub-<label>_hemi-<L|R>_space-fsLR_den-<label>_<surface>.surf.gii
These are useful for plotting CIFTI results on subject anatomy.
* FIX: Stop excluding FS minc_modify_header used during fallback registration (#453)
* ENH: Output fsLR meshes on subject surfaces (#460)
* ENH: Support spatial normalization to alternative modalities (#459)
* ENH: Add `t2w_file` output to `TemplateFlowSelect` (#457)
* MNT: Enable pre-release tests (#461)
* MNT: Complete transition from flake8/black to ruff (#435)
* MNT: Adopt src/ layout and tox (#458)
Closes #447.