Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kianmeng
Copy link

@kianmeng kianmeng commented Aug 29, 2021

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.

Screenshot:
20210829

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.

3. Neither the name of the copyright holder nor the names of its contributors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 1 space

1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.

2. Redistributions in binary form must reproduce the above copyright notice,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 1 space

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 1 space

* thumbnail and scale functions

## v0.0.1 - 2016-04-25
* first version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* crop function

## v0.0.2 - 2016-08-24
* thumbnail and scale functions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* magick attribute is read-write

## v0.0.3 - 2016-08-25
* crop function

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces


## v0.0.4 - 2016-08-30
* dump and load using binaries
* magick attribute is read-write

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* add num_pages

## v0.0.4 - 2016-08-30
* dump and load using binaries

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* bugfix: memory leak on `image_dump/1`

## v0.0.5 - 2016-09-05
* add num_pages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces


## v0.0.6 - 2018-05-17
* add optional dirty scheduler support;
* bugfix: memory leak on `image_dump/1`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v0.0.6 - 2018-05-17
* add optional dirty scheduler support;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 11 possible new issues (including those that may have been commented here).
  • 1 fixed issue! 🎉

See more details about this review.

@kianmeng
Copy link
Author

@thalesmg Should I resolve the sourceleve-bot issue and resubmit the PR again?

@thalesmg
Copy link
Contributor

@kianmeng I recommend asking @nirev , the new maintainer. 🙂

@kianmeng
Copy link
Author

@thalesmg Noted, and thanks.

@nirev
Copy link
Owner

nirev commented Feb 14, 2022

hey, @kianmeng
I just had a look at this. would you mind fixing the source level warnings and resubmitting?

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants