Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vmimi relay timeline improvements v3 #177

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

anatawa12
Copy link
Collaborator

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

残ってたのでapproveしに来た

@anatawa12
Copy link
Collaborator Author

ロールエディタ作り忘れてる

@Sayamame-beans
Copy link

あー、そういえば権限生えてたね…

Copy link

github-actions bot commented Apr 17, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -79542,6 +79542,9 @@
               "globalTimeline": {
                 "type": "boolean"
               },
+              "vmimiRelayTimeline": {
+                "type": "boolean"
+              },
               "hcaptcha": {
                 "type": "boolean"
               },
@@ -79567,6 +79570,7 @@
               "emailRequiredForSignup",
               "localTimeline",
               "globalTimeline",
+              "vmimiRelayTimeline",
               "hcaptcha",
               "turnstile",
               "recaptcha",

Get diff files from Workflow Page

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

雰囲気的には良さそう?(命名規則は本家とは違いそうですが)

@anatawa12
Copy link
Collaborator Author

(命名規則は本家とは違いそうですが)
どこ?

@Sayamame-beans
Copy link

(命名規則は本家とは違いそうですが)

どこ?

localTimeline: instance.policies.ltlAvailable,
globalTimeline: instance.policies.gtlAvailable,
vrtlAvailable: instance.policies.vrtlAvailable,

とか
localTimeline: {
type: 'boolean',
optional: false, nullable: false,
},
globalTimeline: {
type: 'boolean',
optional: false, nullable: false,
},
vrtlAvailable: {
type: 'boolean',
optional: false, nullable: false,
},

とか?

@anatawa12
Copy link
Collaborator Author

変えるつもり無かったので揃えた

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分ヨシ!

@anatawa12 anatawa12 merged commit 81dad3f into niri-la:develop Apr 18, 2024
22 checks passed
@anatawa12 anatawa12 deleted the vmimi-relay-timeline-nirila branch April 18, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants