fix(backend): fallback if sinceId is older than the oldest in cache when using FTT (#14061)
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when using FTT (misskey-dev#14061) * fix(backend): fallback if `sinceId` is older than the oldest in cache when using FTT * Update CHANGELOG.md * chore: fix description of test
Sayamame-beans
commented
Jul 7, 2024
|
|
||
| shouldFallbackToDb = shouldFallbackToDb || (noteIds.length === 0); | ||
| const oldestNoteId = ascending ? redisResultIds[0] : redisResultIds[redisResultIds.length - 1]; |
There was a problem hiding this comment.
redisResultIdsが[]のとき、oldestNoteIdはundefined
|
このPRによるapi.jsonの差分 差分はこちら |
Sayamame-beans
commented
Jul 7, 2024
|
|
||
| shouldFallbackToDb = shouldFallbackToDb || (noteIds.length === 0); | ||
| const oldestNoteId = ascending ? redisResultIds[0] : redisResultIds[redisResultIds.length - 1]; | ||
| shouldFallbackToDb = shouldFallbackToDb || (noteIds.length === 0) || (ps.sinceId != null && ps.sinceId < oldestNoteId); |
There was a problem hiding this comment.
String < undefinedの比較はfalse
There was a problem hiding this comment.
upstreamの問題 && 家のサーバーで問題にならないからいいけどここの(ps.sinceId != null && ps.sinceId < oldestNoteId)はps.useDbFallback &&取ったほうがいいかもね。
|
とりあえずマージしてリリースします？(忘れてた) |
|
してよさそう |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from misskey-dev#14061 (8a9de08)
fix(backend): fallback if
sinceIdis older than the oldest in cache when using FTTUpdate CHANGELOG.md
chore: fix description of test
What
Why
Additional info (optional)
Checklist