Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): original image is not original image on web page #59

Merged
merged 7 commits into from
Sep 26, 2023
Merged

fix(backend): original image is not original image on web page #59

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
272b8f2
fix(backend): original image is not original image on web page
anatawa12 Sep 18, 2023
7c33955
Update packages/backend/src/core/DriveService.ts
anatawa12 Sep 18, 2023
77fdd91
chore(backend): recompress with original size or 8192 pixels
anatawa12 Sep 18, 2023
fbe7f31
docs(changleog): 4K/8K画像が2K以下になってしまうのを修正しました
anatawa12 Sep 18, 2023
7b49144
chore: make maxWebImageSize configurable
anatawa12 Sep 21, 2023
08708ea
Merge branch 'develop' into fix-original-image-is-not-original-image
anatawa12 Sep 25, 2023
707fce9
chore: improve changelog
anatawa12 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/backend/src/core/DriveService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,14 @@ export class DriveService {
const metadata = await img.metadata();
isAnimated = !!(metadata.pages && metadata.pages > 1);

// nirila Extension: We want to keep original size as possible
// noinspection PointlessBooleanExpressionJS
satisfyWebpublic = !!(
type !== 'image/svg+xml' && // security reason
type !== 'image/avif' && // not supported by Mastodon and MS Edge
!(metadata.exif ?? metadata.iptc ?? metadata.xmp ?? metadata.tifftagPhotoshop) &&
metadata.width && metadata.width <= 2048 &&
metadata.height && metadata.height <= 2048
type !== 'image/avif' // not supported by Mastodon and MS Edge
//!(metadata.exif ?? metadata.iptc ?? metadata.xmp ?? metadata.tifftagPhotoshop) &&
anatawa12 marked this conversation as resolved.
Show resolved Hide resolved
//metadata.width && metadata.width <= 2048 &&
//metadata.height && metadata.height <= 2048
);
} catch (err) {
this.registerLogger.warn(`sharp failed: ${err}`);
Expand Down
Loading