User note for featured #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
このPRによるapi.jsonの差分 差分はこちら |
anatawa12
force-pushed
the
user-note-for-featured
branch
from
72ee92a to
38093d7
Compare
|
@Sayamame-beans @niwaniwa ぱっと見で違和感感じるかだけでもいいので一旦は見ていただけるとありがたいです |
|
片方だけblock加味するんです? |
|
雰囲気的には問題なさそうに見えました。(他の類似処理との比較が十分ではないです) |
|
block加味はuser/notesに合わせたので片方だけ。どっかで合わせてもいい気はする |
|
今後やることとして #100 にした |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #96
Why
Additional info (optional)
Checklist