fix(wrangler): only set environment if defined #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Looks good to me 🙂
but...
I am not very familiar with the nuxt/nuxthub codebases, but (and sorry for being potentially annoying 😅) I feel that if this issue is caused by having runtimeConfig.wrangler.environment === '' then the real problem if somewhere up the stack, as runtimeConfig.wrangler.environment should not be set to an empty string, do you by any chance know where this happens and why?
pi0
reviewed
Oct 22, 2024
pi0
reviewed
Oct 22, 2024
| @@ -90,7 +90,7 @@ async function nitroModule(nitro: Nitro) { | |||
| // Dual compatibility with Nuxt and Nitro Modules | |||
| export default function nitroCloudflareDev(arg1: unknown, arg2: unknown) { | |||
| if ((arg2 as Nuxt)?.options?.nitro) { | |||
| (arg2 as Nuxt).hooks.hook("nitro:config", (nitroConfig) => { | |||
| (arg2 as Nuxt).hooks.hookOnce("nitro:config", (nitroConfig) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves nuxt-hub/core#331
I noticed that using
experiment.inlineRouteRules: truecreate this issue for wrangler, making the bindings unavailable:When setting the flag, it seems the
runtimeConfig.wrangler.environment === ''and the platform proxy does not like it, I updated so it is given only if set.I also move from
hooktohookOnceto avoid keeping a watcher.