fix(pkg/narinfo): Treat unknown-deriver as no deriver #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cache servers return `Deriver: unknown-deriver` which breaks verification of a narinfo. Treat such deriver as if no deriver was given at all.
|
Is this a cachix thing, or does nix/hydra also upload NARInfo like this? |
|
Apparently it's a Nix thing - see NixOS/nix@c60715e. Thanks for fixing this, and also for adding a test! |
|
https://cl.tvl.fyi/c/depot/+/12940 applies the same change to nix-compat too. |
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Jan 1, 2025
According to NixOS/nix@c60715e, these were produced by a legacy tool and should be considered as if Deriver was not passed at all. See: kalbasit/ncps#171 Reported-In: nix-community/go-nix#128 Change-Id: If285a11c3275cb3c857c68782bd13473c46f04bf Reviewed-on: https://cl.tvl.fyi/c/depot/+/12940 Reviewed-by: edef <[email protected]> Autosubmit: flokli <[email protected]> Tested-by: BuildkiteCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cache servers return
Deriver: unknown-deriverwhich breaks verification of a narinfo. Treat such deriver as if no deriver was given at all.ref kalbasit/ncps#171